svn commit: samba r12695 - in branches/SAMBA_4_0/source/scripting/libjs: .

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bartlett schrieb:
> On Tue, 2006-01-03 at 17:22 +0000, jelmer at samba.org wrote:
>> Author: jelmer
>> Date: 2006-01-03 17:22:19 +0000 (Tue, 03 Jan 2006)
>> New Revision: 12695
>>
>> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=12695
>>
>> Log:
>> A dot is allowed in NetBIOS names.
>>
>> Modified:
>>    branches/SAMBA_4_0/source/scripting/libjs/provision.js
>>
>>
>> Changeset:
>> Modified: branches/SAMBA_4_0/source/scripting/libjs/provision.js
>> ===================================================================
>> --- branches/SAMBA_4_0/source/scripting/libjs/provision.js	2006-01-03 15:40:05 UTC (rev 12694)
>> +++ branches/SAMBA_4_0/source/scripting/libjs/provision.js	2006-01-03 17:22:19 UTC (rev 12695)
>> @@ -481,11 +481,11 @@
>>  }
>>  
>>  // Check whether a name is valid as a NetBIOS name. 
>> -// FIXME: There are probably more constraints here
>> +// FIXME: There are probably more constraints here. 
>> +// crh has a paragraph on this in his book (1.4.1.1)
>>  function valid_netbios_name(name)
>>  {
>>  	if (strlen(name) > 13) return false;
>> -	if (strstr(name, ".")) return false;
>>  	return true;
>>  }
> 
> I still don't think we should allow a dot here.  It may be allowed by
> crh's rules, but I think we are just asking for pain in Samba4 if we
> allow it.
> 
> Does windows allow such a name in 'system -> computer name'?

I use 'MX.BASE' as the netbios domain name currently on my old samba3
domain, and my windows clients work very well
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFDu55Tm70gjA5TCD8RAvwIAJ46akCm9K9AHb8d/o2q6M1XQe5KaACfcTTO
+zO3mWPelYGavX62Vie0GL0=
=IUqP
-----END PGP SIGNATURE-----