svn commit: samba r13698 - in trunk/source/passdb: .

simo idra at samba.org
Mon Feb 27 15:32:58 GMT 2006


On Mon, 2006-02-27 at 10:37 +0100, Volker Lendecke wrote:
> On Sun, Feb 26, 2006 at 07:23:11PM +0000, idra at samba.org wrote:
> > +		DEBUG(0,("ldapsam_set_primary_group: failed to retieve gid from user's group SID!\n"));
> 
> Little typo :-)
> 
> > +	/* remove the old one, and add the new one, this way we do not risk races */
> > +	smbldap_set_mod(&mods, LDAP_MOD_DELETE, "gidNumber", gidstr);
> > +	smbldap_set_mod(&mods, LDAP_MOD_ADD, "gidNumber", newgidstr);
> 
> For this we have smbldap_make_mod(). This could possibly
> simplify the routine, you don't have to fetch the old
> gidNumber explicitly, smbldap_make_mod() does it for you.

done, thanks
-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org



More information about the samba-technical mailing list