svn commit: samba r13698 - in trunk/source/passdb: .

[Volker Lendecke]

On Sun, Feb 26, 2006 at 07:23:11PM +0000, idra at samba.org wrote:
> +		DEBUG(0,("ldapsam_set_primary_group: failed to retieve gid from user's group SID!\n"));

Little typo :-)

> +	/* remove the old one, and add the new one, this way we do not risk races */
> +	smbldap_set_mod(&mods, LDAP_MOD_DELETE, "gidNumber", gidstr);
> +	smbldap_set_mod(&mods, LDAP_MOD_ADD, "gidNumber", newgidstr);

For this we have smbldap_make_mod(). This could possibly
simplify the routine, you don't have to fetch the old
gidNumber explicitly, smbldap_make_mod() does it for you.

Thanks,

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20060227/0580f0bf/attachment.bin