svn commit: samba r13680 - in trunk/source/passdb: .

[simo]

On Fri, 2006-02-24 at 23:53 +0100, Volker Lendecke wrote:
> On Fri, Feb 24, 2006 at 09:50:42PM +0000, idra at samba.org wrote:
> > Initial work toward a scriptless working ldap setup
> > 
> > This add a create users to ldapsam that is called
> > instead of the add user and add machine scripts if
> > both ldapsam:trusted=yes and ldapsam:editposix=yes
> > are set.
> 
> Thanks.
> 
> Some comments:
> 
> Why do you use pstrings? I wanted to get rid of those as
> much as possible. We have for example talloc_string_sub now
> that makes filter be a pstring unnecessary. Likewise with
> smbldap_talloc_single_attribute and smbldap_talloc_dn.
> 
> Then there's talloc_autofree_ldapmsg() that does right what
> it says.

Right, I'll modify the patch to use these.

> One more: There's init_ldap_from_sam(). Why don't you create
> a SAM_ACCOUNT and re-use that?

Because it does much more than we need and requires an existing
LDAPMessage. That mean I would have to create a new entry, and then
retrieve it, modify and recommit. My implementation does only one ldap
add operation in any case so we do not risk half commits and all the
code needed to deal with rolling back commits if something goes back
after the first one.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org