ACB_ values exceed 16 bits, yet some working variables explicitly declared as uint16

[Andrew Bartlett]

On Wed, 2006-02-22 at 10:53 +0100, Guenther Deschner wrote:
> Hi Andrew,
> 
> On Wed, Feb 22, 2006 at 08:31:06PM +1100, Andrew Bartlett wrote:
> > On Wed, 2006-02-22 at 10:06 +0100, Guenther Deschner wrote:
> > > Hi Luke,
> > > 
> > > On Wed, Feb 22, 2006 at 10:59:35AM +1100, Luke Howard wrote:
> > > > 
> > > > >> But those defined values can exceed 16 bits, for example:
> > > > >> include/smb.h:#define ACB_DONT_REQUIRE_PREAUTH 0x00010000  /* 1 =
> > > > >> Preauth not required */
> > > > >> 
> > > > >   That's odd, I would have expected valgrind to
> > > > >catch something like that, not just the Sun compilers...
> > > > 
> > > > Can't this only to be caught a compile-time, though?
> > > > 
> > > > BTW, where did the new ACB_ bits come from? 
> > > 
> > > There were identified by looking at the acct_flags in the Kerberos PAC
> > > info3.
> > 
> > Are they included in our mapping functions now?
> 
> I'm not sure, I send you a patch a longer while ago to the new bits at
> least to the idl files but that never got added IIRC.

Argh.  Can you please add them?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060222/12c22ac8/attachment.bin