[SAMBA4] svn r13396 breaks platforms with non-C99 sprintf

James Peach jpeach at sgi.com
Wed Feb 8 23:04:41 GMT 2006


Hi Simo,

In r13396, you changed the replaced vsnprintf and snprintf functions to
be smb_vsnprintf and smb_snprintf respectively. These names also need
to be redefined in a header file somewhere to make sure that all the
rest of the code uses the new names.

On IRIX, I've ended up with an smbtorture binary that still uses the libc
(non-C99) snprintf:

nm bin/smbtorture | grep snprin
[1192]  | 276007904|     120|FUNC |GLOB |DEFAULT  |MIPS_TEXT|smb_snprintf
[1706]  | 268862532|     144|FUNC |GLOB |DEFAULT  |UNDEF  |snprintf
[1736]  | 268863132|     120|FUNC |GLOB |DEFAULT  |UNDEF  |vsnprintf
[7250]  | 276007808|      92|FUNC |GLOB |DEFAULT  |MIPS_TEXT|smb_vsnprintf

I'd fix this, but it's not obvious to me what header file the #defines
need to go it (also I wanted this mail in the list archives ;-)) ...

-- 
James Peach | jpeach at sgi.com | SGI Australian Software Group
I don't speak for SGI.



More information about the samba-technical mailing list