NULL vs. zero length DATA_BLOB's in LDAP

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

simo schrieb:
> On Mon, 2006-02-06 at 01:32 +0100, Stefan (metze) Metzmacher wrote:
>> Hi *,
>>
>> I have create a patch to correctly support OPTIONAL elements in the LDAP
>> protocol parser, this really matters for some controls and for some SASL
>> mechs...
>>
>> please review careful, abartlett please compare this with your changes
>> in that area, I'm not really sure what comes outof gensec to seperate
>> NULL vs. zero length...
> 
> Seem ok to me, if you pass tests then please commit.

I'll wait for abartlett.

I also think we should catch the cases where control->data is NULL in
the modules...

e.g.
        asq_ctrl = talloc_get_type(control->data, struct ldb_asq_control);

if that's NULL then we shoulkd return LDAP_ERR_PROTOCOL_ERROR when the
data is needed...

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFD5qXlm70gjA5TCD8RApo9AKCpCLFkMJz9fn2FdQyiszAMjaifOwCfarhu
QAOTSg0iShnf2si5B/Rm7wQ=
=6R7v
-----END PGP SIGNATURE-----