Coding style notes on cifsdd

[Andrew Bartlett]

On Wed, 2006-02-01 at 17:06 +1100, James Peach wrote:
> On Wed, 2006-02-01 at 13:28 +1100, Andrew Bartlett wrote:
> > James,
> > 
> > You asked for feedback on the new cifsdd.  The main points I came up
> > with were style, which just felt 'odd'.  In particular:
> 
> I used to have a very pedantic style, but after a while switching
> between codebases, I now tend to be pretty ad-hoc :)

:-)

> > We don't put a space between * and the variable name
> 
> This is a pet hate of mine. I'll go through and remove these spaces
> tomorrow :(
> 
> > and iosz feeling scarily close to Hungarian notation :-).  
> 
> But it is shorter that io_size, which is a plus. I can go through and
> rename things like this if you'd prefer?

I actually consider the io_size much, much clearer. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060201/816bc58e/attachment.bin