Coding style notes on cifsdd

[Andrew Bartlett]

James,

You asked for feedback on the new cifsdd.  The main points I came up
with were style, which just felt 'odd'.  In particular:

static struct dd_iohandle *
open_fd_handle(const char * path, uint64_t iosz, int options)
{

compared with 

static struct dd_iohandle *open_fd_handle(const char *path, 
					  uint64_t io_size, int options)
{

We don't put a space between * and the variable name, and iosz feeling
scarily close to Hungarian notation :-).  

BTW, never refer to the param/ code for coding style, it's just weird...

Other than that, I'm just waiting for the smb2 support :-)

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060201/a13d0ba5/attachment.bin