r20242?

[Volker Lendecke]

Hi, Simo!

--- nsswitch/wb_client.c        (Revision 20241)
+++ nsswitch/wb_client.c        (Revision 20242)
@@ -65,7 +65,7 @@
 /* Call winbindd to convert sid to name */

 BOOL winbind_lookup_sid(TALLOC_CTX *mem_ctx, const DOM_SID *sid,
-                       const char **domain, const char **name,
+                       char **domain, char **name, enum lsa_SidType *name_type)
 {
        struct winbindd_request request;

Are you certain that this change is correct? It leads to two
warnings in lookup_sid.c. Changing the "const char *domain"
to "char *domain" leads to even more warnings, as for
example lookup_wellknown_name gets its domain from a static
string.

Why do you want that not to be const? In what circumstances
do you want to modify the strings returned from
winbind_lookup_sid? So far we have done quite well without
it.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20061219/67e832ff/attachment.bin