Move change_owner_to_parent from open_file_ntcreate to open_file?

Jeremy Allison jra at samba.org
Sun Dec 17 18:18:19 GMT 2006


On Sun, Dec 17, 2006 at 06:50:03PM +0100, Volker Lendecke wrote:
> Hi, Jeremy!
> 
> Right now I'm trying to consolidate the use of
> parent_dirname (which sucks ;-) a bit. Two users are
> inherit_acls and change_owner_to_parent. The
> open_file_ntcreate path calls parent_dirname potentially
> twice, via both those callers.
> 
> As both inherit_acls change_owner_to_parent logically do
> close things, would moving them together via the attached
> disturb any code path I don't see? Open_file_fchmod (the
> other user of open_file) should not be affected, as it will
> never create the file.

Just glancing at this (hey it's the weekend :-) this
looks like a nice optimization - thanks. I'll take a
closer look monday.

Jeremy.


More information about the samba-technical mailing list