Move change_owner_to_parent from open_file_ntcreate to open_file?

[Volker Lendecke]

On Sun, Dec 17, 2006 at 06:50:03PM +0100, Volker Lendecke wrote:
> Right now I'm trying to consolidate the use of
> parent_dirname (which sucks ;-) a bit. Two users are
> inherit_acls and change_owner_to_parent. The
> open_file_ntcreate path calls parent_dirname potentially
> twice, via both those callers.
> 
> As both inherit_acls change_owner_to_parent logically do
> close things, would moving them together via the attached
> disturb any code path I don't see? Open_file_fchmod (the
> other user of open_file) should not be affected, as it will
> never create the file.

BTW, while looking at it: Why does SMB_SET_FILE_UNIX_BASIC
in the mknod path call inherit_access_acl but not
change_owner_to_parent()?

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20061217/37bf15dc/attachment.bin