svn commit: samba r20225 - in branches/SAMBA_4_0/source/libnet: .

[Rafal Szczesniak]

On Sun, Dec 17, 2006 at 01:33:43PM +0000, metze at samba.org wrote:
> Author: metze
> Date: 2006-12-17 13:33:43 +0000 (Sun, 17 Dec 2006)
> New Revision: 20225
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=20225
> 
> Log:
> we can't use composite_error() in a _recv() function, as that would
> trigger the caller to call the _recv() function again and will be an endless
> loop.

Doh! You're right. Thanks.

> this is just a fix the to prevent this, and use a more usefull error code
> than NT_STATUS_UNSUCCESSFUL
> 
> I think we should move the checks about valid responses into the function
> which receives the the response (here continue_name_found()),
> so that the _recv() function only needs to transfer the output vars to the caller
> without any logic to analyse the network response.

Yes, but on the other hand I'd prefer to leave some of the code in _recv
function to be able to perform some checks when transferring the results
to given memory context. Alternative approach would be to replace all
_recv functions with some generic call, just like dcerpc_ndr_request_recv()


cheers,
-- 
Rafal Szczesniak
Samba Team member  http://www.samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20061217/b8086fe9/attachment.bin