[ldb] [PATCH] LDB_SCOPE_ONELVEL indexing

tridge at samba.org tridge at samba.org
Mon Dec 11 01:58:53 GMT 2006


Simo,

 > We could but ltdb_index_dn_and() clears the dn_list.
 > I just wanted to make a patch without touching anything else, but I can
 > optimize if you think it is better that way.

ahh, yes, we'd have to setup a fake expression tree, and have a new
node type in the tree.

Your approach is indeed simpler - I think you should apply it,
assuming its valgrind clean and passes tests. It will also need some
tests of its own, particularly as it isn't used so it will tend to
bitrot if not tested.

I still think the single record approach is better for the shares
database Volker is looking at. It still requires a lot more operations
to load a share than the single record approach.

Cheers, Tridge


More information about the samba-technical mailing list