[ldb] [PATCH] LDB_SCOPE_ONELVEL indexing
tridge at samba.org
tridge at samba.org
Mon Dec 11 00:20:22 GMT 2006
Simo,
> This patch implements indexing for one level searches but only if
> explicitly activated by adding an attribute called @IDXONE to the
> @INDEXLIST special object.
This certainly ended up a lot simpler than I expected!
A few things could be improved though. The ldb_msg_find_idx() calls
for LTDB_IDXONE seem a bit silly. I think a flag in ltdb->cache makes
more sense.
I also think we could get rid of the ltdb_index_dn_one() function,
which is the most complex function in the patch. Instead, we could do
the onelevel indexing before the attribute indexing in
ltdb_search_indexed(), and call ltdb_index_dn_and().
Cheers, Tridge
More information about the samba-technical
mailing list