svn commit: samba r17930 - in branches/SAMBA_4_0: . source/auth source/auth/ntlmssp source/client source/dsdb/common source/dsdb/samdb source/dsdb/samdb/ldb_modules source/heimdal/lib/asn1 source/kdc source/ldap_server source/lib source/lib/charset source/lib/events source/lib/messaging source/lib/registry/common source/lib/socket source/lib/socket_wrapper source/lib/stream source/lib/tdb/common source/lib/tdr source/lib/util source/libcli/auth source/libcli/cldap source/libcli/composite source/libcli/dgram source/libcli/ldap source/libcli/nbt source/libcli/raw source/libcli/smb2 source/libcli/smb_composite source/libcli/wrepl source/libnet source/librpc/ndr source/librpc/rpc source/nbt_server source/ntvfs source/ntvfs/cifs source/ntvfs/cifs_posix_cli source/ntvfs/common source/ntvfs/ipc source/ntvfs/posix source/ntvfs/simple source/ntvfs/sysdep source/param source/pidl/lib/Parse/Pidl source/rpc_server source/rpc_server/samr source/scripting/ejs source/smb_server source/smb_server/smb source/smbd source/torture source/torture/basic source/torture/ldap source/torture/nbench source/torture/rpc source/torture/smb2 source/web_server source/winbind source/wrepl_server

[Jelmer Vernooij]

On Wed, 2006-08-30 at 09:18 -0400, simo wrote: 
> > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17930
> > 
> > Log:
> > Merge noinclude branch:
> >  * Move dlinklist.h, smb.h to subsystem-specific directories
> >  * Clean up ads.h and move what is left of it to dsdb/ 
> >    (only place where it's used)
> 
> 
> Have you done this on purpose?
> 
> -	do_parameter("smb ports", SMB_PORTS, NULL);
> +	do_parameter("smb ports", "445 139", NULL);
Yes. The reasoning behind this was:
 * All the other parameters were already hardcoded in param/loadparm.c
 * It's being used just here
 * The other defines in smb.h are flags used in just the protocol code

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060830/7413dcca/attachment.bin