svn commit: samba r17860 - in branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules: .

[simo]

On Mon, 2006-08-28 at 12:28 +1000, Andrew Bartlett wrote:
> On Sun, 2006-08-27 at 22:25 -0400, simo wrote:
> > On Mon, 2006-08-28 at 11:53 +1000, Andrew Bartlett wrote:
> > > On Sun, 2006-08-27 at 23:39 +0000, idra at samba.org wrote:
> > > > Author: idra
> > > > Date: 2006-08-27 23:39:09 +0000 (Sun, 27 Aug 2006)
> > > > New Revision: 17860
> > > > 
> > > > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17860
> > > > 
> > > > Log:
> > > > 
> > > > Let's commit the work down up to now on the new schema module.
> > > 
> > > This is an impressive piece of work.
> > > 
> > > > At the moment it is able to validate an object has no conflicting
> > > > objectlasses that it meets the criteria to be inserted as child of
> > > > the parent and also sorts and create the objectclass hierarchy so
> > > > that the objectclass .c module can be obsoleted.
> > > 
> > > How do you sort it?  If you look at my code in the ad2oLschema tool, I
> > > need to read a sorted objectClass list.  We could read the schema in the
> > > same way, and then quicksort based on the index in that list.
> > 
> > Well if you look at schema_add_build_objectclass_list() you will see
> > that I combine, objectclass discovery with ordering.
> > Objectclasses are order by childhood, and the structural hive is the
> > first after top, all other classes come later.
> > 
> > I don't think any other sorting is really necessary, but I am sure I can
> > adapt that function to account for any need.
> 
> The critical part is that a computer *must* have 'computer' as the last
> objectClass, otherwise MMC breaks.

actually as computer is the structural class used to instantiate the
object, this should always be the case, as all other classes are parents
of computer and because of that they are put first.

> I was going to add objectCategory handling to the objectClass module,
> but this should also be handled here.

Yes objectCategory should stay here.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org