Possible dead code in Samba 3

David Collier-Brown davec-b at rogers.com
Thu Aug 17 20:09:29 GMT 2006


   After the discussion of his morning, I did a lint run to
find defined but unused functions, and then looked through
the first few candidates with cscope.

   There were a few false positives, but I found what
appeared some real dead code, for example, aio_finished.
Cscope (and grep) said


Functions calling this function: aio_finished
   File    Function Line
0 proto.h NTSTATUS 7310 BOOL aio_finished(void );
1 aio.c   BOOL      168 BOOL aio_finished(void)
2 aio.c   BOOL      706 BOOL aio_finished(void)
3 proto.h NTSTATUS 7327 BOOL aio_finished(void );

   I have 2043 more lines of probably-dead functions:
anyone want them (;-))

--dave
-----
Could not find the functions calling this function: cancel_pending_lock_requests_by_fid

Could not find the functions calling this function: delete_pipe_opendb

Functions calling this function: dptr_CloseDir
   File    Function Line
0 proto.h NTSTATUS 7424 int dptr_CloseDir(struct dptr_struct *dptr);


Functions calling this function: file_dump_open_table
   File    Function Line
0 proto.h NTSTATUS 7499 void file_dump_open_table(void );


Functions calling this function: file_find_fsp
   File    Function Line
0 proto.h NTSTATUS 7502 files_struct *file_find_fsp(files_struct *orig_fsp);


Functions calling this function: file_find_print
   File    Function Line
0 proto.h NTSTATUS 7505 files_struct *file_find_print(void );


   File    Function Line
0 proto.h NTSTATUS 7617 void *init_quota_handle(TALLOC_CTX *mem_ctx);

Functions calling this function: destroy_quota_handle
   File    Function Line
0 proto.h NTSTATUS 7618 void destroy_quota_handle(void **pqt_handle);

Functions calling this function: add_idle_event
   File    Function Line
0 proto.h NTSTATUS 7756 struct idle_event *add_idle_event(TALLOC_CTX *mem_ctx,


-- 
David Collier-Brown,         | Always do right. This will gratify
System Programmer and Author | some people and astonish the rest
davecb at spamcop.net           |                      -- Mark Twain
(416) 223-5943


More information about the samba-technical mailing list