[PATCH] More details on net ads join when LDAP connect fails

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Aug 14 12:41:10 GMT 2006

On Mon, Aug 14, 2006 at 02:00:36PM +0200, Christian Ambach wrote:
> I was not sure if the DEBUG statement might change the value of errno, so 
> I added errnosave as a safety measure.
> If it's not needed it can definitely be removed.

Just double-checked: The normal DEBUG macro only calls
dbghdr before the arguments are evaluated. And dbghdr has

        /* Ensure we don't lose any real errno value. */
        int old_errno = errno;

I would have been very surprised if DEBUG had destroyed
errno in the way you used it, at least I do it a lot. And if
it had done bad to errno, then DEBUG would be the place to
fix it instead of cluttering all the callers :-)

Checking it in.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20060814/70c46c0f/attachment.bin

More information about the samba-technical mailing list