svn commit: samba r17353 - in branches/SAMBA_3_0: examples examples/gpfs source source/modules source/smbd

Alexander Bokovoy ab at
Wed Aug 2 09:12:55 GMT 2006


On Tue, Aug 01, 2006 at 09:10:45AM -0700, Jeremy Allison wrote:
> ab - I'm not happy with this level of change checked
> in without review.
> Please revert it and post it to the list with reasons
> for the changes.

Attached, please find patch for supporting NFS4-based ACLs in JFS2 for
AIX. Main part of NFS4 ACLs/NT ACLs conversion is done in
modules/nfs4_acls.c smbacl4_nfs42win() and smbacl4_win2nfs4(). This code
was mostly done by Peter Somogyi and he'll fill us on details.

It is in no way complete translation as you noted. The code itself is
isolated under 

SMB_MODULE(vfs_aixacl2, \$(VFS_AIXACL2_OBJ), "bin/aixacl2.$SHLIBEXT", VFS)

in so it does not influence current code except that it
extends existing smbd API with two functions (previously static):
unpack_nt_owners() and try_chown() from smbd/posix_acls.c and they are
used in nfs4_acls.c in the same manner as in posix_acls.c:set_nt_acl() for
chown operation.

The removal of SMB_STRUCT_STAT *psbuf from unpack_nt_owners() arguments is
due to the fact that it is not used at all in this function, though it
might be there due to desire to keep that ACL-management internal API
consistent (all other functions accept SMB_STRUCT_STAT* as its second
parameter). Am I correct?

I'm looking forward for more info from Peter. The code was reviewed by

/ Alexander Bokovoy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: aix-nfs4-acls.patch
Type: text/x-patch
Size: 46024 bytes
Desc: not available
Url :

More information about the samba-technical mailing list