trans2 response handling

[Murali Bashyam]

On 8/1/06, Stefan (metze) Metzmacher <metze at samba.org> wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Stefan (metze) Metzmacher schrieb:
> > Andrew Bartlett schrieb:
> >>> On Mon, 2006-07-31 at 09:22 -0700, Murali Bashyam wrote:
> >>>> Stefan
> >>>>
> >>>> To fix the issue, could we do something like not serialize when we
> are
> >>>> handling trans2 request/responses i.e turn off the serialise flag
> just
> >>>> before and during the whole exchange, and turn it on after the
> exchange?
> >>>> Would this work?
> >>> The correct fix is to return to the main event loop, and handle the
> >>> remainder on a callback.
> >
> > I'm working on a fix...
> >
> > we need to get rid of smbcli_request_receive_more() and handle
> > trans replies special in smbcli_transport_finish_recv().
>
> hmm, this seems to be a bit more complex...
> But I'll look at this the next days...


Converting smb_raw_trans2_recv to not loop and invoke a callback once all
the responses have been accumulated in the trans2 block should work,
correct?

Please file a bug at bugzilla.samba.org so that it didn't get lost
> in case I forget...


I've filed it, the bug id is 3983.

Murali

metze
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.2 (GNU/Linux)
> Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
>
> iD8DBQFEzza5m70gjA5TCD8RAjswAJ43JpvxPZ6A/7ZbXrUB21cN7wY2dACdHN90
> VpqzE4dwiByqo5iPDAB534c=
> =Oh0u
> -----END PGP SIGNATURE-----
>