svn commit: samba r15333 - in branches/SAMBA_3_0/source: .

[Green, Paul]

Jeremy,

I went back to the C manual and read up on this.

Declaring a function that takes no arguments by using an empty list (as
in "()") is the nonprototyped form.
Declaring the same function by using the a list consisting only of
"(void)" is the prototyped form.

Your change is fine.  Prototypes are good.  I guess my PL/I was showing
thru.  I apologize.

Unfortunately, both our in-house C compiler and GCC both passed the
nonprototyped form.  Who had the compiler that barfed at it?

PG


-----Original Message-----
From: samba-cvs-bounces+paul.green=stratus.com at lists.samba.org
[mailto:samba-cvs-bounces+paul.green=stratus.com at lists.samba.org] On
Behalf Of jra at samba.org
Sent: Saturday, April 29, 2006 7:34 PM
To: samba-cvs at samba.org
Subject: svn commit: samba r15333 - in branches/SAMBA_3_0/source: .


Author: jra
Date: 2006-04-29 23:33:39 +0000 (Sat, 29 Apr 2006)
New Revision: 15333

WebSVN:
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=1533
3

Log:
Paulg broke the function prototyping of decl_static_XX.
Needs to be (void), not (). Paulg please check this.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/aclocal.m4


Changeset:
Modified: branches/SAMBA_3_0/source/aclocal.m4
===================================================================
--- branches/SAMBA_3_0/source/aclocal.m4	2006-04-29 23:33:36 UTC
(rev 15332)
+++ branches/SAMBA_3_0/source/aclocal.m4	2006-04-29 23:33:39 UTC
(rev 15333)
@@ -57,7 +57,7 @@
 		string_shared_modules="$string_shared_modules $1"
 	elif test x"$DEST" = xSTATIC; then
 		[init_static_modules_]translit([$4], [A-Z],
[a-z])="$[init_static_modules_]translit([$4], [A-Z], [a-z])  $1_init();"
- 		[decl_static_modules_]translit([$4], [A-Z],
[a-z])="$[decl_static_modules_]translit([$4], [A-Z], [a-z]) extern
NTSTATUS $1_init();"
+ 		[decl_static_modules_]translit([$4], [A-Z],
[a-z])="$[decl_static_modules_]translit([$4], [A-Z], [a-z]) extern
NTSTATUS $1_init(void);"
 		string_static_modules="$string_static_modules $1"
 		$4_STATIC="$$4_STATIC $2"
 		AC_SUBST($4_STATIC)