svn commit: samba r15105 - in trunk/source: . include nsswitch smbd tdb utils

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Apr 18 19:54:51 GMT 2006

On Tue, Apr 18, 2006 at 12:34:47PM +0200, tridge at wrote:
> maybe we should use a tdb_data_t type in both trees to minimise the
> problems with char -> unsigned char?

There's only two places in the code where this gives
warnings: tdb.c:77 and traverse.c:281. Both pointers are
given to memcmp later. memcmp takes a const void *, so why
not change the definition in both lines mentioned to void *?

> I think that would be worthwhile if you don't mind. Hopefully we'll be
> able to have the two trees very close (or even identical) for tdb.

The one that's really different is tdbutil.c. Would it be ok
if I moved that to lib/ directly? I think then we can really
have identical trees apart from that definition in TDB_DATA.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url :

More information about the samba-technical mailing list