svn commit: samba r15105 - in trunk/source: . include nsswitch smbd tdb utils

[Jeremy Allison]

On Tue, Apr 18, 2006 at 03:16:39PM +0200, Guenther Deschner wrote:
> Hi Volker,
> 
> On Mon, Apr 17, 2006 at 05:12:16PM +0200, Volker Lendecke wrote:
> > On Mon, Apr 17, 2006 at 03:07:26PM +0000, vlendec at samba.org wrote:
> > 
> > > This is a backport of the samba4 tdb implementation to samba3. I did one
> > 
> > >    trunk/source/nsswitch/winbindd_cache.c
> > >    trunk/source/nsswitch/winbindd_util.c
> > 
> > Forgot to mention in the commit message: Günther, in winbind
> > you explicitly set the tdb error code to 0. I removed this
> > to get it to compile, this looks a bit wrong to me.
> > 
> > Can you explain why setting the tdb error code from a caller
> > is necessary?
> 
> Sorry, I can't, these were Jeremy's changes. Maybe he can explain.

Yeah I've already told him it was my change. I'll need to look
at it closely. I do recall a possible error code path that
required it.

Jeremy.