[PATCH][SAMBA4] fix inconsistent config summary output

Stefan (metze) Metzmacher metze at samba.org
Wed Apr 5 09:43:46 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

James Peach schrieb:
Hi James,

>  AC_MSG_CHECKING(whether to use pthreads)
> +SMB_EXT_LIB(PTHREAD,[-lpthread])
> +SMB_EXT_LIB_ENABLE(PTHREAD,NO)
> +
>  AC_ARG_WITH(pthreads,
>  [  --with-pthreads              Include pthreads (default=no) ],
>  [ case "$withval" in
> @@ -23,8 +26,6 @@
>  AC_MSG_RESULT(no)
>  )
>  
> -SMB_EXT_LIB(PTHREAD,[-lpthread])
> -

this is not needed as external libs with SMB_EXT_LIB() are off by default

>  AC_MSG_CHECKING(whether to search for setproctitle support)
>  AC_ARG_WITH(setproctitle,
>  [  --with-setproctitle          Search for setproctitle support (default=no)],
> Index: build/smb_build/summary.pm
> ===================================================================
> --- build/smb_build/summary.pm	(revision 14915)
> +++ build/smb_build/summary.pm	(working copy)
> @@ -7,6 +7,13 @@
>  package summary;
>  use strict;
>  
> +sub enabled($)
> +{
> +    my ($val) = @_;
> +
> +    return (defined($val) && $val =~ m/yes|true/i);

does this catch "YES" and "yes"? if so please
commit the changes to this file
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEM5FSm70gjA5TCD8RAqJFAKDElQWKcNU1Hbzp6s6yQOPsgxaAwgCdHKzc
d+cDrVrUFWFsCTPJI2UOyMg=
=C1OR
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list