Samba 4 libnet_join and RPC-JOIN torture test

Andrew Bartlett abartlet at
Tue Sep 13 05:40:58 GMT 2005

On Tue, 2005-09-13 at 07:36 +0200, Stefan (metze) Metzmacher wrote:
> str = talloc_asprintf(tmp_ctx,"Hello World");
> status = libnet_foo(ctx, tmp_ctx, &r);
> NT_STATUS_NOT_OK_RETURN_TMPMEM(status, tmp_ctx);
> abartlet: would you be happy with this?
> (if so I'll add the macros)

Frankly, macros that 'return' inside them scare me, and put off code

Personally, I would simply prefer the spelled out:

if (failcon) {
	return failed;

Andrew Bartlett

Andrew Bartlett                      
Samba Developer, SuSE Labs, Novell Inc.
Authentication Developer, Samba Team 
Student Network Administrator, Hawker College
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list