Samba 4 libnet_join and RPC-JOIN torture test

[Brad Henry]

Brad Henry wrote:

> Andrew Bartlett wrote:
>
>> On Sat, 2005-09-10 at 22:14 -0600, Brad Henry wrote:
>>  
>>
>>> Brad Henry wrote:
>>>
>>>   
>>>
>>>> Hello all,
>>>>
>>>> This patch contains the changes i've made to the libnet join code. 
>>>> I've also created a new torture test RPC-JOIN, and changed 
>>>> torture/rpc/testjoin.c to use this code as well.
>>>>
>>>> The patch is an 'svk diff' against current SAMBA_4_0. There is 
>>>> still a problem which causes the test to segfault once the test is 
>>>> completed and it has returned back to torture.c, but I wanted to 
>>>> get this out and get  some responses.
>>>>     
>>>
>>> The problem was that I was incorrectly passing the machine_password 
>>> variable into torture_join_domain(). Everything is working now as it 
>>> should, so let me know what you think.
>>>
>>> I know this patch is pretty big, I promise to break it up a little 
>>> next time. :)
>>>   
>>
>>
>> I'm still a little unclear on your BDC behaviours.  If we are already a
>> BDC, and 'rejoin' as a member, or we are a member and join as a BDC,
>> what happens?
>>
>> Andrew Bartlett
>>
>>  
>>
> Nothing happens!
> If we are a BDC, and attempt to rejoin as a member, we remain a BDC.
> If we are a member and rejoin as a BDC, we remain a member.
>
> Brad
>
>
That's probably not the best description. What happens is that the 
server remains in its role, and the appropriate libnet_Join or 
libnet_JoinDomain struct is filled in and returned to the caller.