[SAMBA4][PATCH] configure checks for IRIX

Jelmer Vernooij jelmer at samba.org
Thu Sep 8 09:24:49 GMT 2005


Hi James,

On Thu, Sep 08, 2005 at 02:37:40PM +1000, James Peach wrote about '[SAMBA4][PATCH] configure checks for IRIX':
> Hi all,

> The attached patch gets IRIX past the configure stage of samba4. The
> main changes are to work out whether the C compiler needs the -c99
> option to put it into C99 mode, and to use the configure-detected
> preprocessor in yapp.

> If there are no problems, I'll check this is in a couple of days.
> Index: branches/SAMBA_4_0/source/pidl/idl.yp
> ===================================================================
> --- branches/SAMBA_4_0/source/pidl/idl.yp	(revision 10060)
> +++ branches/SAMBA_4_0/source/pidl/idl.yp	(working copy)
> @@ -319,6 +319,7 @@
>  # start code
>  %%

> +use config qw(%config);
>  use Parse::Pidl::Util;

>  #####################################################################
> @@ -422,7 +423,7 @@
>  	undef $/;
>  	my $cpp = $ENV{CPP};
>  	if (! defined $cpp) {
> -		$cpp = "cpp"
> +		$cpp = $config::config{'CPP'};
>  	}
>  	my $data = `$cpp -D__PIDL__ -xc $filename`;
>  	$/ = $saved_delim;
> Index: branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm
> ===================================================================
> --- branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm	(revision 10060)
> +++ branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm	(working copy)
> @@ -2672,6 +2672,7 @@
>  #line 320 "pidl/idl.yp"


> +use config qw(%config);
>  use Parse::Pidl::Util;

>  #####################################################################
> @@ -2775,7 +2776,7 @@
>  	undef $/;
>  	my $cpp = $ENV{CPP};
>  	if (! defined $cpp) {
> -		$cpp = "cpp"
> +		$cpp = $config::config{'CPP'};
>  	}
>  	my $data = `$cpp -D__PIDL__ -xc $filename`;
>  	$/ = $saved_delim;

Please set $ENV{"CPP"} rather then making pidl depend on config.pm.
Pidl can currently run stand-alone and this would make it depend on
Samba's configure.

Looks good, other then that :-)

Cheers,

Jelmer

-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20050908/e1992829/attachment.bin


More information about the samba-technical mailing list