libnet_join

[Brad Henry]

Andrew Bartlett wrote:

>On Sun, 2005-09-04 at 18:12 -0600, Brad Henry wrote:
>  
>
>>Andrew Bartlett wrote:
>>    
>>
>
>  
>
>>I'm getting the hang of valgrind and gdb. I made this change, and this 
>>patch also includes a fix for a problem valgrind found, with 
>>libnet_Join_primary_domain() not passing a talloc()'d libnet_JoinDomain 
>>struct to the libnet_JoinDomain() function.
>>    
>>
>
>It still doesn't look like you are doing a clean seperation between
>parent and temporary memory contexts.  I don't mind if the rule to have
>the 'r' structure be talloced is extended much further, if it results in
>cleaner, more correct code.
>
>Andrew Bartlett
>
>  
>
Hi again,

These two patches should implement libnet_join using the local and 
parent contexts correctly.

Thanks,
Brad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libnet_join.c.diff
Type: text/x-patch
Size: 16406 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20050905/c190e09d/libnet_join.c.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libnet_join.h.diff
Type: text/x-patch
Size: 552 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20050905/c190e09d/libnet_join.h.bin