libnet_join

[Andrew Bartlett]

On Sun, 2005-09-04 at 18:12 -0600, Brad Henry wrote:
> Andrew Bartlett wrote:

> I'm getting the hang of valgrind and gdb. I made this change, and this 
> patch also includes a fix for a problem valgrind found, with 
> libnet_Join_primary_domain() not passing a talloc()'d libnet_JoinDomain 
> struct to the libnet_JoinDomain() function.

It still doesn't look like you are doing a clean seperation between
parent and temporary memory contexts.  I don't mind if the rule to have
the 'r' structure be talloced is extended much further, if it results in
cleaner, more correct code.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Samba Developer, SuSE Labs, Novell Inc.        http://suse.de
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20050905/b9f652aa/attachment.bin