move adt_tree.c (virtual registry tree) to new talloc()
Stefan (metze) Metzmacher
metze at samba.org
Sat Sep 3 07:17:08 GMT 2005
-----BEGIN PGP SIGNED MESSAGE-----
Volker Lendecke schrieb:
> The only comment I have is one of taste: When I touch things like this, I try
> to get rid of the typedefs for structs. I don't see much of a difference in
> typing 'struct sorted_tree' instead of 'SORTED_TREE', only that I like the
> former more.
Yep, I also hate typedef's,
(the following has nothing todo with jerry's patch...)
and typedef's to create pointer types are the most ugly stuff I have every saw in C programms...
just having structs and unions and basic [u]int[8|16|32|64]_t, [s]size_t, int, unsinged,
char and sometimes enums are all you need! it's easy to understand and you can do forward
declarations of structs and unions.
typedef's just make sense for function pointer types, where they really simplify thinks...
Stefan Metzmacher <metze at samba.org> www.samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3-nr1 (Windows XP)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the samba-technical