libmsrpc patch

Gerald (Jerry) Carter jerry at
Fri Sep 2 18:24:56 GMT 2005

Hash: SHA1

Chris Nicholls wrote:
> Hi Jerry,
> Well I got to a good place to 'stop' libmsrpc before the SOC deadline. 
> I've attached a patch against the latest SAMBA_3_0 tree.


I've posted Chris' libmsrpc work to
Public review is welcome.

Chris, I've got to say that I'm extremely impressed.  Really good
for less than 8 weeks worth of work.  I have no problem signing
off on this for google.

Long term, there are a couple of comments:

* The formatting needs to be cleaned up to be integrated
into the SAMBA_3_0 tree.  I think I can get close using

* The TALLOC_CTX should be rewritten to use the talloc
hierarchy functionality.  We could just initially talloc()
the CacServerHandle and use that as the ctx.  That would
remove one of the formal parameters in most of the API.

* Integration with the Jeremy's rpc rewrite in trunk
once that is completed.

* Addition of other pipes

I would like to include libmsrpc in 3.0.21.  That would mean
that the existing interface needs to be stable.  I would really
like you involved on all these future changes and plans if at
all possible.

cheers, jerry
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird -


More information about the samba-technical mailing list