svn commit: samba r11320 - branches/SAMBA_3_0/source/rpc_client trunk/source/rpc_client

[Andrew Bartlett]

On Thu, 2005-10-27 at 08:27 +0000, vlendec at samba.org wrote:
> Author: vlendec
> Date: 2005-10-27 08:27:48 +0000 (Thu, 27 Oct 2005)
> New Revision: 11320
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=11320
> 
> Log:
> Fix error handling for rpccli_netlogon_getdcname. Jeremy, the other functions
> in cli_netlogon look similarly suspicious.

> -	if (NT_STATUS_IS_OK(result)) {
> +	if (NT_STATUS_IS_OK(result = r.status)) {

Frankly, the new version looks even more suspicious, between the macros
and = == typical mixups.  Any reason you didn't use the extra line, per
our more normal style?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Samba Developer, SuSE Labs, Novell Inc.        http://suse.de
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20051027/bd4268b5/attachment.bin