Samba 3.0.20 - findfirst optimization

Jeremy Allison jra at samba.org
Mon Oct 24 18:11:10 GMT 2005


On Mon, Oct 24, 2005 at 10:33:21AM +0200, Dina Fine wrote:
> Hi
> 
> I have a question regarding the findfirst optimization  in 3.0.20
> version.
> It seems that it doesn't work if case-sensitive and mangling are
> configured to yes and the path doesn't contain wild chars
> 
> If a findfirst request is a mangled file name and the case sensitive is
> configured to yes then the stat in dptr_ReadDirName (line 593, dir.c)
> will fail, and since the case sensitive is yes the function will return
> with NULL in line 616.
> The mangling is not considered here at all.

I explicitly don't want to deal with name mangling in the dptr_XXX
and below functions - they need to be clean w.r.t. this. Dealing with
it in upper layers is where it should be. I'll take a look at this
case and fix it above this code path if needed.

Jeremy.


More information about the samba-technical mailing list