svn commit: samba r10945 - in branches/SAMBA_4_0/source/auth/kerberos: .

[Andrew Bartlett]

On Tue, 2005-10-18 at 11:13 +0200, Guenther Deschner wrote:
> Hi Andrew,
> 
> On Thu, Oct 13, 2005 at 09:25:37AM +1000, Andrew Bartlett wrote:
> > On Thu, 2005-10-13 at 00:39 +0200, Guenther Deschner wrote:
> > > On Wed, Oct 12, 2005 at 10:24:43PM +0000, abartlet at samba.org wrote:
> > > > Author: abartlet
> > > > Date: 2005-10-12 22:24:43 +0000 (Wed, 12 Oct 2005)
> > > > New Revision: 10945
> > > > 
> > > > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=10945
> > > > 
> > > > Log:
> > > > Free the salt after we are done with it.  May need a merge to similar
> > > > code in Samba3.
> > > 
> > > Is already fixed in Samba3 :)
> > 
> > Any other bits of our glue code I need to know about?
> 
> Except from the salt (which is fixed in both branches now), I  
> 
> * SAFE_FREE'd the valid_princ_formats in
> libads/kerberos_verify.c:ads_keytab_verify_ticket() and 
> * cleaned up a double krb5_kt_start_seq_get() the same function.
> 
> At least the valid_princ_formats leak is in Samba4 as well, I presume.

Well, I'm killing that code anyway, so it won't leak for much longer ;-)

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Samba Developer, SuSE Labs, Novell Inc.        http://suse.de
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20051018/3e388bc8/attachment.bin