svn commit: samba r11975 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bartlett wrote:

|> ===================================================================
|> --- branches/SAMBA_3_0/source/libsmb/cliconnect.c	2005-11-30 17:07:02
UTC (rev 11974)
|> +++ branches/SAMBA_3_0/source/libsmb/cliconnect.c	2005-11-30 17:29:33
UTC (rev 11975)
|> @@ -163,6 +163,7 @@
|>  	char *p;
|>  	uint32 capabilities = cli_session_setup_capabilities(cli);
|>
|> +	memset(cli->outbuf, '\0', smb_size);
|>  	set_message(cli->outbuf,13,0,True);
|>  	SCVAL(cli->outbuf,smb_com,SMBsesssetupX);
|>  	cli_setup_packet(cli);
|
| Do you *really* want to spend CPU time zeroing every
| packet?  I know we have specifically avoided doing so
| in the past...

The is only in the client session setup code.  No big deal
I don't think.





cheers, jerry


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDjisVIR7qMdg1EfYRAobPAKDMtWy1Q8/QUQ2cbjwPcqSFXx1SWQCeKaj+
LteUvQPt3FT2QhSkPnffl3Q=
=p5AW
-----END PGP SIGNATURE-----