svn commit: samba r11975 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

[Andrew Bartlett]

On Wed, 2005-11-30 at 17:29 +0000, vlendec at samba.org wrote:
> Author: vlendec
> Date: 2005-11-30 17:29:33 +0000 (Wed, 30 Nov 2005)
> New Revision: 11975
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=11975
> 
> Log:
> Fix valgrind error -- bug 3291
> Modified:
>    branches/SAMBA_3_0/source/libsmb/cliconnect.c
>    trunk/source/libsmb/cliconnect.c
> 
> 
> Changeset:
> Modified: branches/SAMBA_3_0/source/libsmb/cliconnect.c
> ===================================================================
> --- branches/SAMBA_3_0/source/libsmb/cliconnect.c	2005-11-30 17:07:02 UTC (rev 11974)
> +++ branches/SAMBA_3_0/source/libsmb/cliconnect.c	2005-11-30 17:29:33 UTC (rev 11975)
> @@ -163,6 +163,7 @@
>  	char *p;
>  	uint32 capabilities = cli_session_setup_capabilities(cli);
>  
> +	memset(cli->outbuf, '\0', smb_size);
>  	set_message(cli->outbuf,13,0,True);
>  	SCVAL(cli->outbuf,smb_com,SMBsesssetupX);
>  	cli_setup_packet(cli);

Do you *really* want to spend CPU time zeroing every packet?  I know we
have specifically avoided doing so in the past...

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20051201/85ed5ef1/attachment.bin