svn commit: samba r11961 - in trunk/source: . lib utils

tridge at tridge at
Wed Nov 30 00:34:49 GMT 2005


 > Yes, it's a copy of talloc_report_full, but uses a Samba3 specific output
 > function I don't think is available in Samba4. I originally tried to use
 > talloc_vasprintf_append() to build the output but kept getting valgrind
 > errors about reusing free'd memory.

can you show me the code that caused that? 

btw, you do know that talloc_vasprintf_append() is like realloc() in
that it can (and often does) change the pointer?

 > I think it was to do with trying to print the string you're
 > constructing as talloc_vasprintf_append() calls
 > talloc_set_name_const with the constructed string.... 

hmm, I don't quite follow this, but perhaps the traversal of the tree
was traversing into the memory that you were using for the traversal?
I can see that tying you in knots. I guess you could check for that at
the top of the function and skip out.

Cheers, Tridge

More information about the samba-technical mailing list