svn commit: samba r11658 - in branches/SAMBA_3_0/source: .

Green, Paul Paul.Green at
Fri Nov 11 13:48:43 GMT 2005

> Jeremy Allison wrote:
|> Jerry Carter wrote:
|> Log:
|> Someone broke the initialization of the static modules by adding a
|> 'NTSTATUS' declaration before their call.
|> The compiler sees : { NTSTATUS fn_foo(); NT_STATUS fn_bar(); } as 
|> *definitions: They need to be : { fn_foo(); fn_bar(); } Jeremy.
| Strangely enough this was only broken in SAMBA_3_0, not HEAD. Odd.
>That was Paul checkin.  Sorry Paul.

Yeah, I was going to reply with "That wasn't someone, that was me."  I
am not hiding. I did it. However, I most certainly tested this change
(one two platforms, VOS and SuSE Linux) and I can assure you that it is
a good change.  I can also assure you that it is a most necessary change
for gcc on VOS. 

Oddly enough, it broke on the build farm machine that I myself run --
berks!!  This is a fairly slow machine (~300 MHz).  The log shows that
the build exceeded the time limit...

Would you mind if I restore the change?

Would you further mind if I raised the time limit so we don't get
bamboozled again?

Paul Green, Senior Technical Consultant,
Stratus Technologies, Maynard, MA USA
Voice: +1 978-461-7557; FAX: +1 978-461-3610

More information about the samba-technical mailing list