svn commit: samba r11604 - in branches/SAMBA_4_0/source/kdc: .

[Stefan Metzmacher]

On Wed, Nov 09, 2005 at 11:13:03AM +0000, tridge at samba.org wrote:
>  	talloc_free(tmp_ctx);
> -	return;
> +	return NT_STATUS_OK;
>  nomem:
>  	status = NT_STATUS_NO_MEMORY;
> +
>  failed:
>  	kdc_tcp_terminate_connection(kdcconn, nt_errstr(status));
> +	return NT_STATUS_OK;
>  }

shouldn't this be 'return status;'? If not please add a comment why.

> +	kdcconn->packet = packet_init(kdcconn);
> +	if (kdcconn->packet == NULL) {
> +		stream_terminate_connection(conn, "kdc_tcp_accept: out of memory");
> +		return;
> +	}

can you please add that check also to the smb server?

I like the new packet code! I'll convert the winbind and winsrepl server later.

metze