[PATCH] Volume serial number

Alexander Bokovoy ab at altlinux.ru
Mon Nov 7 20:35:09 GMT 2005

On Mon, Nov 07, 2005 at 12:04:49PM -0800, Jeremy Allison wrote:
> On Mon, Nov 07, 2005 at 03:06:06PM -0500, Alexander Bokovoy wrote:
> > On Mon, Nov 07, 2005 at 11:00:47AM -0800, Jeremy Allison wrote:
> > > > > This is a really simple patch for Samba3 so I'm inclined to
> > > > > just add it in. I can't see any possible conflicts with Samba4.
> > > > We do it differently so it is not good to have different behaviour.
> > > 
> > > Well Samba3 has been generating these volume-id's using a hash
> > > on the name for a long time. Samba4 uses the ino from the directory
> > > containing the share. It doesn't use a uuid. We're not talking
> > > about the same thing. Samba4 uses uuids in RAW_QFS_OBJECTID_INFORMATION:
> > > which in Samba3 is returned as zero.
> > Yes, that's correct -- I've been wrong and actually mixed them up. Does it
> > make sense to unify the code for both paths and:
> > 	- return hash of uuid or smb.conf-set value for volume-id
> > 	- return uuid or smb.conf-set value for object-id
> We can't change the volumeid calculation on Samba3 as there
> may be software out there that is using the volumeid to
> determine if it was installed there (that's why the person
> wanted to be able to manually set it). If we change it now
> people's installed software will break.
That is the biggest concern... Then I have nothing against the patch.

> The object-id stuff is fair game as it's not returned in
> Samba3 right now.
Ok, then I'll port Samba4 object-id to Samba3. And port forward volume-id
to Samba4.

/ Alexander Bokovoy
Samba Team                      http://www.samba.org/
ALT Linux Team                  http://www.altlinux.org/
Midgard Project Ry              http://www.midgard-project.org/

More information about the samba-technical mailing list