[PATCH] Volume serial number

Alexander Bokovoy ab at samba.org
Mon Nov 7 15:18:08 GMT 2005

On Sat, Nov 05, 2005 at 12:22:38PM -0500, derrell at samba.org wrote:
> Nikolai Zhubr <zhubr at mail.ru> writes:
> > This is my second attempt to submit this patch,
> > the first one seems to stay totally unnoticed.
> > Please someone tell me if this is a wrong place
> > to come out with patches?
> Nikolai,
> Thank you for providing the patch!  This is a fine place to submit it,
> although a better way is via bugzilla.samba.org.  Using bugzilla ensures that
> it doesn't get forgotten.
> Upon initial review, your patch looks clean.  A possible issue I see is if the
> supplied volume serial number begins with hex digits but erroneously ends with
> non-hex characters.  It looks like your handle_volume_id() function wont
> detect that.
> Jeremy, since you typically apply patches in this area, would you like to do
> this?
> Nikolai, if you don't get a response soon, go ahead and enter this into
> bugzilla so it doesn't get lost.
This needs to be coordinated with my code in Samba4 for volume id
management. I'm intending to port it back to Samba 3 and put a smb.conf
override too.
/ Alexander Bokovoy
Samba Team                      http://www.samba.org/
ALT Linux Team                  http://www.altlinux.org/
Midgard Project Ry              http://www.midgard-project.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20051107/3d8be931/attachment.bin

More information about the samba-technical mailing list