Bug 2663 update

[Satwik Hebbar]

Yes, Derrell, this patch solves the problem. However, there is a tiny  
error in the patch. In cli_getattrE, the function calls for a_time and  
c_time are to make_unix_date2, whereas for m_time it is to make_unix_date,  
which gives the wrong value for the modified time. If you change this to  
make_unix_date2, as I did, you will find everything works fine. So, I  
guess the patch does work.

Thanks,
Satwik.

On Tue, 10 May 2005 16:27:31 -0400, <derrell at samba.org> wrote:

> "Satwik Hebbar" <satwikh at calsoftinc.com> writes:
>
>> Hi Derrell,
>>
>> I finally found the time from my tight project deadlines to make a small
>> python program that you can use to test that the cli_setattrE function
>> doesn't work and that the cli_setatr works for now, but it shouldnt if  
>> the
>> time conversions were fixed.
>
> Satwik,
>
> I've taken a look at your patch and the test program you sent.  I see  
> that I
> misread your initial message, and that it's cli_setattrE() that does not  
> work
> correctly.  libsmbclient currently uses only cli_setatr() which explains  
> why I
> have not been able to reproduce the problem that you're reporting.
>
> Unfortunately, changing the functions put_dos_date3() and  
> make_unix_date3() as
> you suggest will break lots of other working code (samba server uses  
> those
> functions).  I believe, however, that I found a bug that would not be  
> seen in
> the samba server but that you might see with your direct calls to
> cli_setattrE(), and I'd like you to try the following patch to see if it  
> fixes
> your problem.  I see that in the samba server, in parsing an SMBsetattrE  
> PDU,
> the code is using different date conversion routines than cli_setattrE()  
> is
> using.
>
> Please let me know if this patch solves your problem.  (Note that you  
> should
> undo your other time.c and clifile.c changes prior to applying this  
> patch.)
> If this doesn't solve the problem, I'll have to look into it further  
> since we
> can't do the time function patch that you suggested.
>
> Thanks,
>
> Derrell
>



-- 
------------------------------------------------------------
If you're free you'll never see the walls
If you're head is clear you'll never freefall
If you're out right you never fear the wrong
If you're head is high you never fear at all
------------------------------------------------------------