svn commit: samba r6127 - in branches/SAMBA_3_0/source: include lib libads libsmb nsswitch rpc_server tdb utils

[derrell at samba.org]

"Christopher R. Hertel" <crh at ubiqx.mn.org> writes:

>> There's no reason that I can think of not to have -Wall in CFLAGS all the
>> time.  --enable-developer isn't obvious, and for those who don't know about
>> that (as I didn't and surely most of the non-team developers don't), errors
>> can be missed that the compiler could have caught.  I try to use -Wall in
>> everything I work on.  Compilers these days are just too good not to take
>> advantage of the bugs they can discover.
>
> The reason generally given is that there are many, many non-developers out
> there who download, build, and install Samba from the original sources.  
> They just want it to work.
>
> Those folks shouldn't need to worry about the types of messages generated 
> by -Wall.
>
> True, we should be cleaning up all such warnings *before* the code goes 
> out the door.  Removing -Wall from the default compile is simply a hedge.

This is EXACTLY my point.  If we have -Wall as a default option, we'll clean
up our own code (and find bugs earlier) before it ever goes out the door.
There's no reason that we should ever be shipping code that generates
warnings, even with -Wall turned on.

Derrell