svn commit: samba r6074 - in branches/SAMBA_4_0/source/libcli/composite: .

Andrew Tridgell tridge at osdl.org
Sun Mar 27 00:12:10 GMT 2005


Andrew,

 > Thanks for fixing that.  Jeremy pointed it out to me, but I still don't
 > understand how adding the 'return' here fixes it...

It's not the "return" that helps, its the filling in of the user and
domain fields.

Error handling is still broken if cli_credentials_get_username()
returns NULL. The caller will get a failure, but won't have any way to
determine why it failed. Fixing that requires more than a few line
patch.

Cheers, Tridge


More information about the samba-technical mailing list