svn commit: samba r6008 - in trunk/source/rpc_server: .

[Jeremy Allison]

On Wed, Mar 23, 2005 at 11:02:19PM +0100, Simo Sorce wrote:
> On Wed, 2005-03-23 at 21:45 +0000, jra at samba.org wrote:
> > Author: jra
> > Date: 2005-03-23 21:45:46 +0000 (Wed, 23 Mar 2005)
> > New Revision: 6008
> > 
> > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6008
> > 
> > Log:
> > Add privillage check for SE_DISK_OP (is this the right privilage?)
> 
> No, I don't think this is the right privilege, and honestly I do not
> think we really need a privilege here yet.
> 
> The message sent with message_send_pid will be reject if you are not
> root so there is no harm with this function afaik.
> 
> Can we revert this change? I will add a proper privilege wrapper
> function when we want to extend it to let other users than root to use
> the function.

I'd rather leave a privilage check in place so we know we need
something here, rather than depending on "I'm sorry sir, I didn't
know you were root." :-).

You can comment it out, but don't revert it - I don't want to
forget this.

Jeremy.