svn commit: samba r5981 - in branches/SAMBA_3_0/source/libsmb: .

[Jeremy Allison]

On Wed, Mar 23, 2005 at 07:28:53AM -0600, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> jra at samba.org wrote:
> | Author: jra
> | Date: 2005-03-22 23:45:57 +0000 (Tue, 22 Mar 2005)
> | New Revision: 5981
> |
> | WebSVN:
> http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=5981
> |
> | Log:
> | Hack to fix DFS code to work with Win98 server. JERRY PLEASE REVIEW THIS !
> | I don't think this is correct - it just happens to work and fix bug #2530
> | to return all the files.
> 
> Jeremy,
> 
> This one is confusing.  A WIn98 server cannot be a dfs root.  So
> the cli_state->dfsroot flag should never be set.  We should have
> never reached the cli_dfs_check_error() call.  Do you have any
> traces with the error?

Revert the patch and just connect using smbclient to a Win98
box. Then just type ls. It'll return the error I check for in
the patch.

Jeremy.