A small patch for C++ VFS modules.

[Ben Martin]

On Thu, 2005-06-23 at 15:38 +0400, Alexander Bokovoy wrote:
> On Thu, Jun 23, 2005 at 05:15:52PM +1000, Ben Martin wrote:
> > OK patch attached this time :/
> Could you make it against current SVN for SAMBA_3_0? There were changes,
> particulary in popt and VFS support which clutter your patch: 

Ok no worries. A new patch will arrive shortly. Now that I know there is
interest in such changes :)

> 
> > diff -Nuar samba-3.0.10-vanilla/source/include/vfs.h samba-3.0.10/source/include/vfs.h
> > --- samba-3.0.10-vanilla/source/include/vfs.h	2004-10-26 07:05:06.000000000 +1000
> > +++ samba-3.0.10/source/include/vfs.h	2005-06-11 15:55:18.468163000 +1000
> > @@ -224,7 +224,7 @@
> >  		ssize_t (*pwrite)(struct vfs_handle_struct *handle, struct files_struct *fsp, int fd, const void *data, size_t n, SMB_OFF_T offset);
> >  		SMB_OFF_T (*lseek)(struct vfs_handle_struct *handle, struct files_struct *fsp, int fd, SMB_OFF_T offset, int whence);
> >  		ssize_t (*sendfile)(struct vfs_handle_struct *handle, int tofd, files_struct *fsp, int fromfd, const DATA_BLOB *header, SMB_OFF_T offset, size_t count);
> > -		int (*rename)(struct vfs_handle_struct *handle, struct connection_struct *conn, const char *old, const char *new);
> > +		int (*rename)(struct vfs_handle_struct *handle, struct connection_struct *conn, const char *old, const char *new_str /*MIQ*/ );
> >  		int (*fsync)(struct vfs_handle_struct *handle, struct files_struct *fsp, int fd);
> >  		int (*stat)(struct vfs_handle_struct *handle, struct connection_struct *conn, const char *fname, SMB_STRUCT_STAT *sbuf);
> >  		int (*fstat)(struct vfs_handle_struct *handle, struct files_struct *fsp, int fd, SMB_STRUCT_STAT *sbuf);
> Any change in VFS layer require increasing VFS version number.

I'm not sure I follow here, if changes are limited to renaming 
"char* new" -> "char* newstr" 
in the header doesn't that retain all VFS version number compatibility?

> 
> And following part is autogenerated file and should not be in the patch:

oops, I should look closer at the cleaning options to wipe these out.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20050623/4f54a176/attachment.bin