svn commit: samba r8843 - in trunk/source: include libsmb nsswitch rpc_client rpc_parse rpc_server rpcclient

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

jra at samba.org wrote:

| Log:
| Unravel the rats nest of includes in rpc code - only use one include,

I think you just made the rat's nest worse.

| Removed:
|    trunk/source/include/rpc_buffer.h

I don't really agree with the everything in one
include file.  The RPC_BUFFER structure does not really
belong in ntdomain.h IMO.  This is how we end up
duplicating structure all the time become no one can find
anything in messy jumbles of headers.

But I'll defer to you on it.  I just think this will cause
more confusion than it helps.  Headers files should relate to
one aspect or data structure.  ntdomain.h is a mess.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFC6WhFIR7qMdg1EfYRAr2MAJ9gjV0mAUNW+Zg2KxzzggbzKs2HuACeL67o
Z1L2fwm9btTpUItdzFnCL4g=
=5nyG
-----END PGP SIGNATURE-----