svn commit: samba r8493 - branches/SAMBA_3_0/source/lib trunk/source/lib

[Guenther Deschner]

Hi Andrew,

On Sat, Jul 16, 2005 at 09:00:59AM +1000, Andrew Bartlett wrote:
> On Fri, 2005-07-15 at 13:24 -0500, Gerald (Jerry) Carter wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > > According to MSKB 141714 the %LOGONSERVER% variable should be
> > > substituted like our %L-variable.
> > 
> > >  		case 'L' : 
> > > -			if (local_machine_name && *local_machine_name)
> > > +			if (local_machine_name && *local_machine_name) {
> > > +				if (IS_DC)
> > > +					string_sub(p, "\%LOGONSERVER\%", local_machine_name, l);
> > >  				string_sub(p,"%L", local_machine_name,l); 
> > > -			else {
> > > +			} else {
> > 
> > Guenther,
> > 
> > For some reason this makes me feel icky.  I know why you are doing it
> > but I'd rather see a generic means of support long name variables
> > using a consistent syntax.  Care to discuss this some more?
> 
> This seems odd to me too, but for a different reason.  I always assumed
> that this was evaluated on the client side, as a windows environment
> variable.

I think you are right here.

> Can someone show this being set on SAMR, but being different in a
> netlogon reply, or some other way to show that the server munges it?

I will proof-test that.

Thanks a lot,

Guenther

-- 
Günther Deschner                    GPG-ID: 8EE11688
Novell / SUSE LINUX                       gd at suse.de
Samba Team                              gd at samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20050719/71f59724/attachment.bin